jaynuine/fdf
2
0
Fork 0
Code Issues 21 Pull requests Projects 1 Releases Wiki Activity

geometry curling back on itself #24

New issue
Closed
opened 2026-02-27 01:52:40 +00:00 by jaynuine · 1 comment
jaynuine commented 2026-02-27 01:52:40 +00:00
Owner
Copy link

in perspective projection geometry will fold onto itself when advancing the camera along the x axis

in perspective projection geometry will fold onto itself when advancing the camera along the x axis
jaynuine added this to the todo project 2026-02-27 01:52:40 +00:00
jaynuine added this to the bonus milestone 2026-02-27 01:53:15 +00:00
jaynuine referenced this issue from a commit 2026-04-30 08:13:37 +00:00
#21 #24
jaynuine commented 2026-04-30 08:18:14 +00:00
Author
Owner
Copy link

this was happening because we didn't take the signs of the vector's components in urot, as if they are opposed, the resulting angle from asin should be negated
currently this was fixed by bodging a negation on negative x values, but really this should depend on the xor of the signs being positive (or multiplying sgn(vector.x) * sgn(vector.y))

also we were reseting the norm to 1 if it were 0 so as to avoid dividing by zero in the call to asin, which explains why the geometry was mirrored on the x axis and didn't just disappear

this was happening because we didn't take the signs of the vector's components in urot, as if they are opposed, the resulting angle from asin should be negated currently this was fixed by bodging a negation on negative x values, but really this should depend on the xor of the signs being positive (or multiplying `sgn(vector.x) * sgn(vector.y)`) also we were reseting the norm to 1 if it were 0 so as to avoid dividing by zero in the call to asin, which explains why the geometry was mirrored on the x axis and didn't just disappear
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
ft
draft
dragons
No results found.
Labels
Clear labels   
bug

   
mlx
No labels
bug
mlx
Milestone
Clear milestone
No items
No milestone
bonus
Projects
Clear projects
No items
No project
todo
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaynuine/fdf#24
No description provided.